-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(state-viewer): list actions invoked by each contract #8483
feat(state-viewer): list actions invoked by each contract #8483
Conversation
first half-way decent implementation
@pugachAG maybe you can review this? It's an extention to the tool you alraedy reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me!
tools/state-viewer/src/commands.rs
Outdated
}); | ||
|
||
filter.write_header(&mut std::io::stdout().lock())?; | ||
let streaming = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please add a comment explaining why we need a variable with hardcoded false
value here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, that's missing an implementation :)
Added now. Can you please take another look? @pugachAG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock merging.
List account names with contracts deployed and additional information about the contracts. See the state-viewer README for docs and examples. This has been used to produce reports in near#8427
List account names with contracts deployed and additional information about the contracts. See the state-viewer README for docs and examples. This has been used to produce reports in near#8427
List account names with contracts deployed and additional
information about the contracts.
See the state-viewer README for docs and examples.
This has been used to produce reports in #8427