Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(state-viewer): list actions invoked by each contract #8483

Merged
merged 15 commits into from
Feb 3, 2023

Conversation

jakmeier
Copy link
Contributor

@jakmeier jakmeier commented Feb 1, 2023

List account names with contracts deployed and additional
information about the contracts.

See the state-viewer README for docs and examples.

This has been used to produce reports in #8427

@jakmeier jakmeier requested a review from pugachAG February 1, 2023 16:58
@jakmeier jakmeier requested a review from a team as a code owner February 1, 2023 16:58
@jakmeier jakmeier requested a review from mzhangmzz February 1, 2023 16:58
@jakmeier
Copy link
Contributor Author

jakmeier commented Feb 1, 2023

@pugachAG maybe you can review this? It's an extention to the tool you alraedy reviewed.

Copy link
Contributor

@pugachAG pugachAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me!

tools/state-viewer/src/commands.rs Outdated Show resolved Hide resolved
});

filter.write_header(&mut std::io::stdout().lock())?;
let streaming = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add a comment explaining why we need a variable with hardcoded false value here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, that's missing an implementation :)
Added now. Can you please take another look? @pugachAG

tools/state-viewer/src/contract_accounts.rs Outdated Show resolved Hide resolved
tools/state-viewer/src/contract_accounts.rs Outdated Show resolved Hide resolved
tools/state-viewer/src/contract_accounts.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@akhi3030 akhi3030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock merging.

@jakmeier jakmeier requested a review from pugachAG February 3, 2023 12:44
@near-bulldozer near-bulldozer bot merged commit 6587fbd into near:master Feb 3, 2023
@jakmeier jakmeier deleted the view-contracts-and-actions branch February 3, 2023 15:05
nikurt pushed a commit to nikurt/nearcore that referenced this pull request Feb 6, 2023
List account names with contracts deployed and additional 
information about the contracts.

See the state-viewer README for docs and examples.

This has been used to produce reports in near#8427
nikurt pushed a commit to nikurt/nearcore that referenced this pull request Feb 13, 2023
List account names with contracts deployed and additional 
information about the contracts.

See the state-viewer README for docs and examples.

This has been used to produce reports in near#8427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants